Skip to content

Code Quality: Added missing "LayerSize="16" to icons #15929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Aug 3, 2024

Resolved / Related Issues
Many Icons had not explicitly had a LayerSize of 16 assigned, the 12px Icons and the 28px icons had their sizes applied.

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 changed the title Added "LayerSize="16" to the icons which did not have it Code Quality: Added missing "LayerSize="16" to icons Aug 4, 2024
@yaira2 yaira2 requested a review from 0x5bfa August 4, 2024 14:42
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 4, 2024
@yaira2 yaira2 merged commit 173730b into files-community:main Aug 4, 2024
6 checks passed
@mdtauk mdtauk deleted the mdta-IconSizeAdding branch August 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants