Code Quality: ThemedIcon, Changed IsToggle to ToggleBehavior #15948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have marked this as ready for review, I have updated the examples page now the Hierarchal paging has been merged into main. |
0x5bfa
force-pushed
the
mdta-ThemedIcon-ToggleFix
branch
2 times, most recently
from
1cac8c6 to
188216f
Compare
0x5bfa
force-pushed
the
mdta-ThemedIcon-ToggleFix
branch
from
5d3773a to
2224cb1
Compare
|
Details of changes:
|
marcelwgn
reviewed
Aug 20, 2024
src/Files.App.Controls/ThemedIcon/ThemedIconLayer/ThemedIconLayer.Consts.cs
Outdated
Show resolved
Hide resolved
src/Files.App.Controls/ThemedIcon/ThemedIconLayer/ThemedIconLayer.Consts.cs
Outdated
Show resolved
Hide resolved
Resolved requests from @marcelwgn
|
Can you resolve the merge conflicts? |
yaira2
previously approved these changes
Sep 16, 2024
|
It seems to be an accessibility issue, do the tests successfully run locally? |
|
I fixed the CI but the xaml formatter is failing. |
|
Let's format manually so we can merge. |
|
Up for review and merge |
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.