Skip to content

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 11, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 marked this pull request as draft August 11, 2024 16:14
@yaira2 yaira2 marked this pull request as ready for review August 11, 2024 19:50
@yaira2 yaira2 requested a review from 0x5bfa August 11, 2024 19:50
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, looks good to me, otherwise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this class abstract class?

@yaira2 yaira2 merged commit aca294a into main Aug 12, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 12, 2024
@yaira2 yaira2 deleted the ya/Terminal branch August 29, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants