Skip to content

Fix: Fixed issues with opening certain file formats #16102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 29, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Created a zip file named "a.zip"
  2. Created a text file named "a.zip.txt"
  3. Set default text editor to VS Code and confirmed that the file opened correctly
  4. Confirmed the python script @Josh65-2201 created outputs the correct folder

@yaira2
Copy link
Member Author

yaira2 commented Aug 29, 2024

The drawback of this change is that it will eliminate the functionality for cycling through photos. However, since this feature is currently not working as intended, we will need to rewrite the code regardless. See issue #15409.

In the event we figure out the issue with NeighboringFilesQuery and come up with a solution, we can add a condition to use LaunchFileAsync for photos.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c75d3d7 into main Aug 30, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 30, 2024
@yaira2 yaira2 deleted the ya/FixLaunchPath branch September 4, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: File with double extensions don't open correctly Bug: Opening items doesn't pass correct path to launched application
2 participants