Code Quality: Update .gitignore
#16197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Sep 15, 2024
0x5bfa
reviewed
Sep 15, 2024
yaira2
reviewed
Sep 15, 2024
.gitignore
Outdated
| @@ -181,6 +204,9 @@ publish/ | |||
| PublishScripts/ | |||
|
|
|||
| # NuGet Packages | |||
| *.nupkg | |||
There was a problem hiding this comment.
We have a package in our source code SevenZipSharp.1.0.2.nupkg so it's best to avoid this change.
There was a problem hiding this comment.
Why isn't this on NuGet? Isn't this deprecated?
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh I see, I'll remove it from the ignore - why don't you publish this (slightly) more maintained library to NuGet?
There was a problem hiding this comment.
Wouldn't it be easier to update then?
Done on my phone! Lol
yaira2
approved these changes
Sep 16, 2024
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
.gitignorefile with the one in the head https://github.com/github/gitignore repoThis is not a strictly necessary change but contains some exclusions that add to the code quality.