Skip to content

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Oct 29, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Maximized the window
  2. Right clicked an item on the home page (on the edge of the screen)
  3. Confirmed the context menu was fully shown

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, LGTM.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 29, 2024
@yaira2 yaira2 merged commit 9d798a8 into main Oct 29, 2024
7 checks passed
@yaira2 yaira2 deleted the ya/ContextPlacement branch October 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Right-click menu on homepage
2 participants