Skip to content

Code Quality: Implemented OwlCore.Storage #16900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2025
Merged

Code Quality: Implemented OwlCore.Storage #16900

merged 4 commits into from
Mar 20, 2025

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Mar 5, 2025 •
edited
Loading

Resolved / Related Issues

This PR transitions the old storage abstractions to the OwlCore.Storage package. Advantages include:

  • Superior support of the abstractions and bundled implementation
  • More extensions on IFile and IFolder interfaces
  • Unified API set and compatibility with other 3rd party OwlCore.Storage implementations

Steps used to test these changes

  • Ran the app and manually tested affected parts

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 5, 2025

This needs further testing before it can be merged

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 15, 2025

@0x5bfa

0x5bfa
0x5bfa reviewed Mar 15, 2025
View reviewed changes
@yaira2 yaira2 changed the title Transition to OwlCore.Storage Code Quality: Implemented OwlCore.Storage Mar 16, 2025
@yaira2 yaira2 requested a review from 0x5bfa March 16, 2025 22:56
0x5bfa
0x5bfa approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the previous review was resolved, everything LGTM!

@yaira2 yaira2 requested a review from 0x5bfa March 19, 2025 22:09
0x5bfa
0x5bfa approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yaira2
yaira2 reviewed Mar 20, 2025
View reviewed changes
@yaira2 yaira2 merged commit 84efbc2 into files-community:main Mar 20, 2025
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 20, 2025
@0x5bfa 0x5bfa mentioned this pull request May 13, 2025
Merged
@d2dyno1 d2dyno1 mentioned this pull request Jul 24, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

+1 more reviewer

@0x5bfa 0x5bfa 0x5bfa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d2dyno1 @yaira2 @0x5bfa