Skip to content

Code Quality: Replaced Shimmer control with official version from WCT #16926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 13, 2025

Resolved / Related Issues

None

Steps used to test these changes

  1. Open Files app
  2. Go to a folder that has numerous items
  3. Change layouts and see Shimmer in the all llayouts works fine

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WCTShimmer branch from 48ce248 to 8a2754b Compare March 13, 2025 16:22
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 13, 2025
@yaira2 yaira2 merged commit d770b7e into files-community:main Mar 13, 2025
6 checks passed
@yaira2 yaira2 changed the title Code Quality: Replaced our own Shimmer control with WCT Code Quality: Replaced Shimmer control with WCT Mar 13, 2025
@yaira2 yaira2 changed the title Code Quality: Replaced Shimmer control with WCT Code Quality: Replaced Shimmer control with official version from WCT Mar 13, 2025
@0x5bfa 0x5bfa deleted the 5bfa/CQ-WCTShimmer branch March 14, 2025 07:44
zp7D

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants