Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 14, 2020

Fixes #1713, fixes #1626, fixes #1451

Fix crash when trying to rename a file with "double tap to rename files" turned off

Related AppCenter issues: 1, 2

@gave92 gave92 marked this pull request as draft August 14, 2020 07:47
@ghost ghost added the needs - code review label Aug 14, 2020
@gave92 gave92 marked this pull request as ready for review August 14, 2020 08:02
@gave92
Copy link
Member Author

gave92 commented Aug 14, 2020

@yaichenbaum I just saw this issue: #651
Says that it's ok if renaming does not work when "double-tap to rename" is turned off.
Why is it ok? Are we planning to remove the "double-tap to rename" option (leaving it always on)?

@jaigak
Copy link
Contributor

jaigak commented Aug 14, 2020

@gave92 How did you get access to App Center for Files UWP?

@gave92
Copy link
Member Author

gave92 commented Aug 14, 2020

@Jaiganeshkumaran @yaichenbaum gave me access

@yaira2
Copy link
Member

yaira2 commented Aug 14, 2020

@gave92 The option to turn off double tap to rename is because of a different issue where it prevents the user from opening the file when double clicking.

@gave92
Copy link
Member Author

gave92 commented Aug 14, 2020

@yaichenbaum Thanks for the info. After seeing that post I was not sure whether this PR made sense or not.

@yaira2 yaira2 self-requested a review August 14, 2020 18:55
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 14, 2020
@yaira2 yaira2 changed the title Fix crash when renaming Fixed several rename issues Aug 14, 2020
@yaira2 yaira2 merged commit a5ca73f into files-community:master Aug 14, 2020
@gave92 gave92 mentioned this pull request Aug 15, 2020
@gave92 gave92 deleted the issue_1713 branch August 15, 2020 11:10
@gave92 gave92 mentioned this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
3 participants