Fixed an issue loading recent items on the home page #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tsvietOK
approved these changes
Aug 16, 2020
yaira2
added
ready to merge
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1645
Loading recent files list may cause files to be downloaded from OneDrive.
Trying to read a file with
streamReader.Peek();will trigger the download of the file if such file is in OneDrive and marked "online-only".That piece of code was added to remove files opened from a disconnected android/MTP phone, so this PR adds a check to only call
streamReader.Peek();if the file was on a MTP phone. This will avoid to risk downloading the file.This PR also adds handling for a couple more exceptions in
PopulateRecentsList()that were seen in crash reports on AppCenter (at this point it might make sense to justcatch (Exception) {..