Added strings for the share dialog #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaigak
commented
Aug 18, 2020
jaigak
commented
- Now when you share a single item, the item name will be mentioned.
- Sharing multiple items will show how many items are being shared.
- Share menu item is now disable on unsupported devices (e.g. Xbox). This is the first step in making Files UWP truly universal across Windows devices.
- All strings related to the share dialog are localized.
Merge master into master
Update latest
Merge latest branch
|
@tsvietOK No space is required otherwise it will appear like 'Sharing 1items'. |
tsvietOK
reviewed
Aug 18, 2020
| <target state="new">The selected item will be shared</target> | ||
| </trans-unit> | ||
| <trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve"> | ||
| <source>Sharing {0}</source> |
There was a problem hiding this comment.
It is better to use Sharing {0} {1} and string.Format(ResourceController.GetTranslation("ShareDialogTitle"), items.Count, ResourceController.GetTranslation("ItemsCount.Text"))
There was a problem hiding this comment.
Please, update translation files too.
ghost
added
the
yaira2
approved these changes
Aug 18, 2020
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.