Skip to content

Revert "Added strings for the share dialog" #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "Added strings for the share dialog" #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Files.Launcher/FolderNames.cs
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions Files/BaseLayout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,6 @@ private async void MenuLayoutItem_Click(object sender, RoutedEventArgs e)
public void RightClickItemContextMenu_Opening(object sender, object e)
{
SetShellContextmenu();
if (!DataTransferManager.IsSupported())
{
UnloadMenuFlyoutItemByName("ShareItem");
}

var selectedFileSystemItems = App.CurrentInstance.ContentPage.SelectedItems;

// Find selected items that are not folders
Expand Down
25 changes: 6 additions & 19 deletions Files/Interacts/Interaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,19 +621,17 @@ private async void Manager_DataRequested(DataTransferManager sender, DataRequest
{
DataRequestDeferral dataRequestDeferral = args.Request.GetDeferral();
List<IStorageItem> items = new List<IStorageItem>();
DataRequest dataRequest = args.Request;

/*dataRequest.Data.Properties.Title = "Data Shared From Files";
dataRequest.Data.Properties.Description = "The items you selected will be shared";*/
DataRequest dataRequest = args.Request;
dataRequest.Data.Properties.Title = "Data Shared From Files";
dataRequest.Data.Properties.Description = "The items you selected will be shared";

foreach (ListedItem item in CurrentInstance.ContentPage.SelectedItems)
foreach (ListedItem item in App.CurrentInstance.ContentPage.SelectedItems)
{
if (item.IsShortcutItem)
{
if (item.IsLinkItem)
{
dataRequest.Data.Properties.Title = string.Format(ResourceController.GetTranslation("ShareDialogTitle"), items.First().Name);
dataRequest.Data.Properties.Description = ResourceController.GetTranslation("ShareDialogSingleItemDescription");
dataRequest.Data.SetWebLink(new Uri(((ShortcutItem)item).TargetPath));
dataRequestDeferral.Complete();
return;
Expand All @@ -651,23 +649,12 @@ private async void Manager_DataRequested(DataTransferManager sender, DataRequest
}
}

if (items.Count == 1)
{
dataRequest.Data.Properties.Title = string.Format(ResourceController.GetTranslation("ShareDialogTitle"), items.First().Name);
dataRequest.Data.Properties.Description = ResourceController.GetTranslation("ShareDialogSingleItemDescription");
}
else if (items.Count == 0)
if (items.Count == 0)
{
dataRequest.FailWithDisplayText(ResourceController.GetTranslation("ShareDialogFailMessage"));
dataRequest.FailWithDisplayText("Could not access file(s) for sharing");
dataRequestDeferral.Complete();
return;
}
else
{
dataRequest.Data.Properties.Title = string.Format(ResourceController.GetTranslation("ShareDialogTitleMultipleItems"), items.Count,
ResourceController.GetTranslation("ItemsCount.Text"));
dataRequest.Data.Properties.Description = ResourceController.GetTranslation("ShareDialogMultipleItemsDescription");
}

dataRequest.Data.SetStorageItems(items);
dataRequestDeferral.Complete();
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.de-DE.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,22 +1139,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.es-ES.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,22 +1126,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.fr-FR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,22 +1132,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.he-IL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,22 +1128,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.hi-IN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,22 +1129,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.it-IT.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,22 +1128,6 @@
<source>Invalid item</source>
<target state="translated">Elemento non valido</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.ja-JP.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,22 +1132,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.nl-NL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,22 +1130,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.or-IN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,22 +1129,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.pl-PL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,22 +1130,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,22 +1128,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.ru-RU.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,22 +1126,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.ta.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,22 +1131,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
16 changes: 0 additions & 16 deletions Files/MultilingualResources/Files.tr-TR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,22 +1130,6 @@
<source>Invalid item</source>
<target state="new">Invalid item</target>
</trans-unit>
<trans-unit id="ShareDialogFailMessage" translate="yes" xml:space="preserve">
<source>There's nothing to share right now</source>
<target state="new">There's nothing to share right now</target>
</trans-unit>
<trans-unit id="ShareDialogMultipleItemsDescription" translate="yes" xml:space="preserve">
<source>The items you've selected will be shared</source>
<target state="new">The items you've selected will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogSingleItemDescription" translate="yes" xml:space="preserve">
<source>The selected item will be shared</source>
<target state="new">The selected item will be shared</target>
</trans-unit>
<trans-unit id="ShareDialogTitle" translate="yes" xml:space="preserve">
<source>Sharing {0}</source>
<target state="new">Sharing {0}</target>
</trans-unit>
</group>
</body>
</file>
Expand Down
Loading