Skip to content

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Aug 21, 2020

Closes #1382

@d2dyno1 d2dyno1 requested a review from yaira2 August 22, 2020 17:04
@tsvietOK
Copy link
Contributor

tsvietOK commented Aug 22, 2020

Additionally we need to disable ability to rename Drive volume label through properties as for the moment this function is not supported.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Aug 22, 2020

Ok, disabled the drive rename by keeping the OriginalItemName null in the DriveProperties and then checking if it's not null

@d2dyno1
Copy link
Member Author

d2dyno1 commented Aug 22, 2020

Forgot my phone 📱 does not have IntelliSense🤦‍♂️

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 23, 2020
@yaira2 yaira2 changed the title Implemented ability to rename files/folders in the properties window Implemented the ability to rename files/folders from the properties window Aug 23, 2020
@yaira2 yaira2 merged commit 1eb8a2d into files-community:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to rename a file by changing the name in the properties window
4 participants