Skip to content

Improved context menu load time #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 13, 2020

Fixes #1873

@yaichenbaum Could you test this and confirm if there's any improvement on first-time context menu opening? Thanks!

Edit: there's an issue in Release mode

@ghost ghost added the needs - code review label Sep 13, 2020
@gave92 gave92 marked this pull request as draft September 13, 2020 10:01
@gave92 gave92 force-pushed the issue_1873_slow_contextmenu branch from 1e39c84 to 0d62f0e Compare September 13, 2020 12:00
@gave92 gave92 marked this pull request as ready for review September 13, 2020 12:00
@yaira2 yaira2 self-requested a review September 13, 2020 13:16
@yaira2
Copy link
Member

yaira2 commented Sep 13, 2020

@gave92 There is still a delay, but it's still an improvement.

@yaira2 yaira2 changed the title [To be tested] - Improve context menu load time Improved context menu load time Sep 13, 2020
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 13, 2020
@yaira2 yaira2 merged commit 7f63050 into files-community:master Sep 13, 2020
@gave92 gave92 deleted the issue_1873_slow_contextmenu branch September 13, 2020 16:54
ChihweiLHBird pushed a commit to ChihweiLHBird/files-uwp that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new right click context menu is slow when opening
2 participants