-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fixed two issues with keyboard navigation #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 77 in the file SidebarControl.xaml
IsTabStop
is also set to False
. Can you fix that as well?
@duke7553 Can you look at this? |
@Thomas1664 This property value doesn't affect functionality, does it? |
@duke7553 It does. Disabling tab stop will prevent keyboard tab navigation for the UI element |
@Jaiganeshkumaran @Thomas1664 Sorry, but what you said is incorrect for this case. The changes I already made allow for using tab because tab stop is enabled for the items themselves already. Unless you want to have a discussion about removing the custom template for these sidebar items altogether (which I'd support), there is no need to change the template value because it already works fine with my changes. Would enabling the template value for the tab stop give us any more benefits? In my testing, the sidebar items already work as intended. |
@duke7553 Although your changes already work, it would be better for code style if you removed the remaining |
@Thomas1664 Since the template itself was redundant, I just got rid of it so we use the standard resources now. |
Sonds great |
Fixes #2020
Fixes #2036