Skip to content

Added support to display custom folder icons #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2020
Merged

Added support to display custom folder icons #2094

merged 4 commits into from
Oct 15, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 14, 2020

Fixes #2083, fixes #519

@gave92
Copy link
Member Author

gave92 commented Oct 14, 2020

@xpoppyx could you verify if this PR works for the use-case you reported in #519?

lukeblevins
lukeblevins reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gave92 Does the WinRT StorageFolder.GetThumbnailAsync() return custom folder icons? Maybe we could check if that method returns a non-default thumbnail and display it for folders as well. I know we currently don't use it anywhere because we use our custom folder icons, but this use case would be reasonable if at all feasible.

@gave92
Copy link
Member Author

gave92 commented Oct 14, 2020 •
edited
Loading

@duke7553 It returns both default and custom folder icons and that's what I'm using.
The issue is that you have to check if the icon is a custom or default one.

@lukeblevins
Copy link
Contributor

@gave92 Ok you're right! I missed that.

lukeblevins
lukeblevins previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't have done it better myself!

@gave92
Copy link
Member Author

gave92 commented Oct 14, 2020 •
edited
Loading

@xpoppyx thanks for the feedback.
Regarding the shortcuts this was expected. Even for file shortcuts we show the icon of the destination and not of the shortcut itself

@gave92
Copy link
Member Author

gave92 commented Oct 14, 2020 •
edited
Loading

Thanks @xpoppyx I can too confirm this.
EDIT: should be fixed now!

yaira2
yaira2 previously approved these changes Oct 15, 2020
View reviewed changes
@yaira2 yaira2 changed the title Show folder custom icons Added support for custom folder icons Oct 15, 2020
@yaira2 yaira2 changed the title Added support for custom folder icons Added support to display custom folder icons Oct 15, 2020
@lukeblevins lukeblevins self-requested a review October 15, 2020 15:31
lukeblevins
lukeblevins previously approved these changes Oct 15, 2020
View reviewed changes
@gave92 gave92 dismissed stale reviews from lukeblevins and yaira2 via ac90de5 October 15, 2020 17:13
@yaira2
Copy link
Member

yaira2 commented Oct 15, 2020

:shipit:

@yaira2 yaira2 mentioned this pull request Oct 15, 2020
Closed
@yaira2 yaira2 merged commit 04709ad into files-community:master Oct 15, 2020
@gave92 gave92 deleted the custom_folder_icons branch October 15, 2020 17:44
@Starz0r Starz0r mentioned this pull request Jan 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

+1 more reviewer

@lukeblevins lukeblevins lukeblevins left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Colorize extension
3 participants
@gave92 @lukeblevins @yaira2