Skip to content

Fix issues with icon overlays #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix issues with icon overlays #2157

merged 1 commit into from
Oct 26, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 26, 2020

Changes in this PR:

  • Do not show icon overlay for shortcut files
  • Fix issue of icon overlay appearing way too small for some programs (e.g. MEGA client)
  • Small refactor to remove code duplication

@gave92
Use large overlay icon instead of extralarge
94b9577 
Do not show overlay for shortcuts
@gave92 gave92 requested a review from yaira2 October 26, 2020 18:45
@gave92 gave92 merged commit f9a9292 into files-community:master Oct 26, 2020
@gave92 gave92 deleted the fix_iconoverlay branch October 26, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2