Skip to content

Fixed an issue where screen readers will wrongly read files and folders as Files.Filesystem.ListedItem #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 6, 2020

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented Oct 30, 2020

Note: This doesn't work in DataGrid. I will open another pull request for data grid list view layout mode.

Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@jaigak jaigak requested a review from yaira2 October 30, 2020 13:33
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 30, 2020
jaigak and others added 4 commits November 5, 2020 20:40
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@yaira2
Copy link
Member

yaira2 commented Nov 5, 2020

@Jaiganeshkumaran Can you fix the generated files so that they are up to date?

yaira2
yaira2 previously approved these changes Nov 6, 2020
@yaira2
Copy link
Member

yaira2 commented Nov 6, 2020

@Jaiganeshkumaran Can you solve the merge conflicts?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 6, 2020
@jaigak
Copy link
Contributor Author

jaigak commented Nov 6, 2020

@yaichenbaum Done

@yaira2 yaira2 merged commit 122f2f1 into files-community:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants