Skip to content

Reduced font size for the drives widget space text #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Reduced font size for the drives widget space text #2429

merged 2 commits into from
Nov 24, 2020

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 24, 2020

image
Fixes #2428

@yaira2 yaira2 requested a review from gave92 November 24, 2020 17:50
@gave92
Copy link
Member

gave92 commented Nov 24, 2020

Should we also change the text wrapping to "NoWrap"/"CharacterEllipsis"? (just in case it's still too long)
Having it in two lines it's possibly even worse that having it cut

@yaira2
Copy link
Member Author

yaira2 commented Nov 24, 2020

Should we also change the text wrapping to "NoWrap"? (just in case it's still too long)

It's fine if it wraps to the second line, and it won't get cut off anymore since I made the text smaller.

@gave92
Copy link
Member

gave92 commented Nov 24, 2020

Ok so this won't happen anymore right? Even if the text wraps
image

gave92
gave92 previously approved these changes Nov 24, 2020
@yaira2
Copy link
Member Author

yaira2 commented Nov 24, 2020

Ok so this won't happen anymore right? Even if the text wraps
image

Correct.

@gave92
Copy link
Member

gave92 commented Nov 24, 2020

Looks good [and no, I won't ask you to add "MaxLines="2"" just to be even more sure xD]

@gave92
Copy link
Member

gave92 commented Nov 24, 2020

Aha you really did it 😆

@yaira2 yaira2 merged commit 1f38c31 into master Nov 24, 2020
@yaira2 yaira2 deleted the Drives branch November 24, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avaibale space in storages are not completely shown in Spanish
2 participants