Skip to content

Added an empty space where there are no columns in the DataGrid layout #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 15, 2020

Fixes #1040

@xpoppyx could you verify whether this PR leads to the desired behaviour?

@yaira2 yaira2 self-requested a review December 15, 2020 21:36
@yaira2
Copy link
Member

yaira2 commented Dec 15, 2020

@gave92 Can you check if the separator between the headers and the content is missing for you?

@gave92
Copy link
Member Author

gave92 commented Dec 15, 2020

@xpoppyx issue is only with drag-select right? just clicking should be ok

@gave92
Copy link
Member Author

gave92 commented Dec 15, 2020

@xpoppyx latest commit should fix the issue with drag-select 👍
[Also, what do you use for screen recording?]

@yaira2 yaira2 changed the title Add empty space where there is no column Added an empty space where there are no columns in the DataGrid layout Dec 15, 2020
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 15, 2020
@yaira2
Copy link
Member

yaira2 commented Dec 15, 2020

@gave92 Great work!

@yaira2 yaira2 merged commit 5b97e04 into files-community:master Dec 15, 2020
@gave92 gave92 deleted the issue_1040 branch December 16, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants