Fixed an issue where opening the properties window would crash the app #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.Ui.Xaml.NavigationView. Resolved files-community#2537.
yaira2
added
the
ready to merge
yaira2
approved these changes
Dec 16, 2020
yaira2
changed the title
|
@winston-de Great work! |
|
@yaichenbaum Thanks! |
Definitely, this change should be considered a work around until the issue is fixed on the WinUI end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am mostly certain that issue #2537 is caused by a bug in the Microsoft.Ui.Xaml NavigationView.
Switching to the Windows.Ui NavigationView seems to be an effective workaround to this bug.