Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 23, 2020

Fir #2447

This PR:

  • handles errors that can be thrown by StorageFolder.GetFolderFromPathAsync()
  • allows to search inside hidden folders (shallow search only)
  • fix a bug for which returned hidden items were not filtered by search term
  • fix a bug for which results were ordered by file name instead of search rank
  • return at most *maxItemsCount` results
  • small code refactor

@gave92 gave92 requested a review from lukeblevins December 23, 2020 22:15
@yaira2
Copy link
Member

yaira2 commented Dec 23, 2020

fix a bug for which results are ordered by file name instead of search rank

@gave92 This was done intentionally so that the most relevant items would show on the quick search drop down. Is there a way to have the drop-down sort by name and have the search results page sort by rank?

@gave92
Copy link
Member Author

gave92 commented Dec 23, 2020

@yaichenbaum mmm I'm not getting the most relevant results atm.

Example search:
I'm looking for files named "test". If in the current path I have a folder also named "test" in the dropdown I get all the files contained inside the "test" folder. Instead I'd like to see files matching "test" first.

Doesn't sorting by rank guarantee that I get the most relevant results?
If they are sorted by filename I get a lot of uninteresting stuff instead

@gave92 gave92 requested review from yaira2 and removed request for lukeblevins December 23, 2020 22:34
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 23, 2020
@yaira2 yaira2 changed the title Enable search inside hidden folders Enabled search inside hidden directories Dec 23, 2020
@yaira2 yaira2 merged commit ad28843 into files-community:master Dec 23, 2020
@yaira2
Copy link
Member

yaira2 commented Dec 23, 2020

@gave92 Great work!

@gave92 gave92 deleted the search_hidden branch December 24, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants