Fixed an issue where there was a delay when deleting items

[Don-Vito]

Fixes #2672
Fixes #2732

There is a significant lag on deletion, especially when numerous files are deleted.
This is significantly impacted by checking whether the file is in Recycle Bin.

This PR somewhat helps by:

• Delaying the check until the dialog presentation
  (resolves the issue for those who disabled the dialog)
• Instead of searching in recycle bin just use path to decide
  if the item is under recycle bin

[gave92]

Thanks a lot for this. I'm not sure why we check if we are deleting a file from recycle bin that way when we could just check if the file path starts with "X:\$Recycle.Bin"..

[Don-Vito]

@gave92 - agree. Do you want me to implement this?

[gave92]

Yes please! (Obvious note: the file path of a recycle bin element can start with any drive letter, not just "C:\")

[gave92]

The same happens in FilesystemOperations.cs -> you can maybe just change the implementation of IsRecycleBinItem

[Don-Vito]

IsRecycleBinItem

I prefer to introduce a new helper: as probably we still want to have a function that actively checks if the file is in recycle bin

[gave92]

Depending on the scope of this PR you might also optimize the call to List<ShellFileItem> items = await recycleBinHelpers.EnumerateRecycleBin(); in FilesystemOperations so it's only called once when deleting many items.

[Don-Vito]

@gave92 - finally had a lunch time to squeeze a bit of coding 😄
I am not sure what is the best way to approach the List<ShellFileItem> items = await recycleBinHelpers.EnumerateRecycleBin(); as it seems that we really need shell file items there.
Probably this could be postponed.

[gave92]

@Don-Vito yup I'm didn't mean to remove it, I meant that when you delete a bunch of file that thing is called for every file, while it would be more efficient to call it once at the end.
It's not necessary to do this change here though

[Don-Vito]

@Don-Vito yup I'm didn't mean to remove it, I meant that when you delete a bunch of file that thing is called for every file, while it would be more efficient to call it once at the end.
It's not necessary to do this change here though

I can followup on this 😊 I will try to create an issue later on.

[gave92]

@Don-Vito for reference: Files Code-Style

[Don-Vito]

@d2dyno1, @gave92 - thanks.. and sorry - didn't touch C# fort the last 8 years :)

[Don-Vito]

@gave92 - anything I can do to help pushing it forward? 👼

[gave92]

@Don-Vito this change looks good to me, I'll approve it as soon as I can test it 👍