Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to access drive properties by right clicking on the drive widget #3285

Merged
merged 17 commits into from
Jan 25, 2021

Conversation

suvrat29
Copy link
Contributor

@suvrat29 suvrat29 commented Jan 25, 2021

Added the ability to open drive properties from the home widgets. This closes #2232

Moved handling to A: and B: drives under unknown case. This will set the icons of A: (or B:) drive(s) as floppy drive if the connected media is not recognized by files.
Added the ability to open drive properties fron the home widgets.
@suvrat29 suvrat29 changed the title Access Drives properties by right clicking widgets Access drive properties by right clicking widgets Jan 25, 2021
@suvrat29 suvrat29 changed the base branch from main to ColumnView January 25, 2021 06:15
@suvrat29 suvrat29 changed the base branch from ColumnView to main January 25, 2021 06:16
Now each of the drive types have their own icons in the tab.
@suvrat29
Copy link
Contributor Author

The last commit is for issue #3195

@tsvietOK
Copy link
Contributor

@suvrat29 Is cfc7970 it a part of this PR?

@suvrat29
Copy link
Contributor Author

suvrat29 commented Jan 25, 2021

@suvrat29 Is cfc7970 it a part of this PR?

No, it is for a separate issue. But it won't let me create a new PR since this was open, and all commits were being appended to this PR.

@tsvietOK
Copy link
Contributor

You can create separate branch for this change in your repo.

@suvrat29
Copy link
Contributor Author

I was having some trouble with that today(see the above commits today). But I'll try again. Will you be removing the commit from this PR?

@tsvietOK
Copy link
Contributor

Can you create new branch with name drive_icons?

@suvrat29
Copy link
Contributor Author

suvrat29 commented Jan 25, 2021

Done. Created a new branch with name drive_icons

tsvietOK
tsvietOK previously approved these changes Jan 25, 2021
@tsvietOK tsvietOK added the ready to merge Pull requests that are approved and ready to merge label Jan 25, 2021
@yaira2 yaira2 changed the title Access drive properties by right clicking widgets Added the option to access drive properties by right clicking on the drive widget Jan 25, 2021
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed ready to merge Pull requests that are approved and ready to merge labels Jan 25, 2021
New string resource DrivesWidgetContextFlyoutPropertiesMenuItem has been added.
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jan 25, 2021
@yaira2 yaira2 merged commit fbf2cd7 into files-community:main Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access Drives properties by right clicking widgets
3 participants