-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the option to access drive properties by right clicking on the drive widget #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved handling to A: and B: drives under unknown case. This will set the icons of A: (or B:) drive(s) as floppy drive if the connected media is not recognized by files.
Added the ability to open drive properties fron the home widgets.
Add missing budles key
suvrat29
changed the title
Access Drives properties by right clicking widgets
Access drive properties by right clicking widgets
Jan 25, 2021
tsvietOK
reviewed
Jan 25, 2021
tsvietOK
reviewed
Jan 25, 2021
Fixed automatic formatting done by Visual Studio.
Now each of the drive types have their own icons in the tab.
The last commit is for issue #3195 |
tsvietOK
reviewed
Jan 25, 2021
You can create separate branch for this change in your repo. |
I was having some trouble with that today(see the above commits today). But I'll try again. Will you be removing the commit from this PR? |
Can you create new branch with name |
Done. Created a new branch with name |
…ives" This reverts commit cfc7970.
tsvietOK
previously approved these changes
Jan 25, 2021
tsvietOK
added
the
ready to merge
Pull requests that are approved and ready to merge
label
Jan 25, 2021
yaira2
changed the title
Access drive properties by right clicking widgets
Added the option to access drive properties by right clicking on the drive widget
Jan 25, 2021
yaira2
requested changes
Jan 25, 2021
yaira2
added
changes requested
Changes are needed for this pull request
and removed
ready to merge
Pull requests that are approved and ready to merge
labels
Jan 25, 2021
New string resource DrivesWidgetContextFlyoutPropertiesMenuItem has been added.
yaira2
approved these changes
Jan 25, 2021
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
changes requested
Changes are needed for this pull request
labels
Jan 25, 2021
tsvietOK
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to open drive properties from the home widgets. This closes #2232