Fixed an issue where changing the theme settings wasn't working correctly #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…page can be captured for dynamic theme switching
tsvietOK
reviewed
Jan 27, 2021
tsvietOK
approved these changes
Feb 13, 2021
tsvietOK
added
ready to merge
yaira2
changed the title
|
@AndyMDoyle Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3291
Sorry, my bad.
I didn't realise that ThemeHelper was setting the theme on elements by capturing a reference to the MainPage. I assumed it was relying on Application.RequestedTheme and changing this.
Balance is restored, and ThemeHelper has had some unused code removed. ThemeHelper.RootTheme has been refactored slightly to make it responsible for reading the value from one place (LocalSettings), and setting ThemeHelper.RootTheme will persist this change back to LocalSettings and call ApplyTheme() to have the current theme applied across the application.