Added a dialog to warn users when changing file extensions

[jusso-dev]

Adds enhancement for issue #1340

#1340

Added warning to warn users before changing file extension. Mirrors the wording of the classic Windows File Explorer.

I'm also happy to:

• Move warning message to common strings file
• Create separate private method that contains popup dialog logic
• Perform any other changes to conform with project standards

Great project! thanks a lot for the review :)

[tsvietOK]

@jusso-dev Seems like shortcut renaming is now broken.

[jusso-dev]

@jusso-dev Seems like shortcut renaming is now broken.

I'm investigating a clean approach to fix this.

[tsvietOK]

@jusso-dev Now renaming doesn't working at all.

[jusso-dev]

@tsvietOK - Pushed another fix, things I manually tested as working:

Renaming files - ✅
Renaming Shortcuts - ✅
Renaming folders - ✅
Selecting Yes on rename of file, folders and shortcuts - ✅
Select No on rename of file, folders and shortcuts - ✅

[tsvietOK]

@jusso-dev Now dialog is displayed when changing file name without extension change.

[jusso-dev]

@tsvietOK When you are free I would appreciate you reviewing this again and merging if possible

[tsvietOK]

@jusso-dev Now dialog is not displayed when changing file extension. By the way, resolve conflicts, please.

[jusso-dev]

@tsvietOK - Hate to be that person but it's working for me, every test I run locally works, so not sure what to say. If it's still not working for you I'll close this PR.

[tsvietOK]

@jusso-dev I'll check again a bit later.

[d2dyno1]

😳

[jusso-dev]

@d2dyno1 I don't know how that happened, all these commits, merges, merge conflicts have stuffed this pull request, my change is small less than 20 line code change, plus some other unnecessary, unrelated changes that were introduced into this specific branch.

[tsvietOK]

Branch fixed.

[yaira2]

@jusso-dev Thank you, great work!