Show localized names for system folders #3561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move makes gridview refresh like a Collection Reset event This reverts commit 7a2eca6.
yaira2
requested review from
tsvietOK and
yaira2
and removed request for
tsvietOK
|
@gave92 What kind of impact will this have on performance? |
|
@yaichenbaum it should have almost no impact as the localized name is loaded in LoadExtendedItemProperties. Reading the name from cache should also be pretty fast. I haven't noticed slow downs in C:\Windows\System32 (big folder with lots of subfolders). Have you seen something different in your testing? |
yaira2
added
the
ready to merge
|
@gave92 There doesn't really seem to be any major impact, good work! |
yaira2
previously approved these changes
Feb 14, 2021
|
Aha sorry now it's ready I think. |
yaira2
approved these changes
Feb 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1226
This PR adds support for showing localized folder names (e.g. "Programmi" instead of "Program Files" for it-IT)
Does not slow down file loading, display name is loaded in LoadExtendedItemProperties() (if not cached).
@jakoss I've employed your caching feature to save the display name for files, I'd be happy if you could take a look at the code to see if there's anything amiss ;)
Note: This PR contains some changes done by @hez2010 for #3350 (also needed here)