Skip to content

Conversation

nvi9
Copy link
Contributor

@nvi9 nvi9 commented Feb 24, 2021

Closes #3696

This PR also includes changes for showing localized Home and Recycle bin items in the startup pages list.

@nvi9 nvi9 marked this pull request as ready for review February 24, 2021 22:18
yaira2
yaira2 previously approved these changes Feb 24, 2021
@yaira2 yaira2 requested a review from gave92 February 24, 2021 22:52
@yaira2 yaira2 changed the title Ability to add Home and recent folders as startup pages Added the ability to add the Home directory as a startup page Feb 25, 2021
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 26, 2021
@yaira2
Copy link
Member

yaira2 commented Feb 26, 2021

@nvi9 Great work! LGTM

@yaira2 yaira2 merged commit 2a939a3 into files-community:main Feb 26, 2021
@nvi9
Copy link
Contributor Author

nvi9 commented Feb 26, 2021

Umm @yaichenbaum shouldn't we change the added string keys as discussed earlier?

<data name="Browse" xml:space="preserve">
<value>Browse</value>
</data>
<data name="RecentLocations" xml:space="preserve">
<value>Recent locations</value>
</data>

@yaira2
Copy link
Member

yaira2 commented Feb 26, 2021

@nvi9 Can you remind me what we decided?

@nvi9
Copy link
Contributor Author

nvi9 commented Feb 26, 2021

We usually name it based on where it's being used, for example, a confirm dialog might have a string called ConfirmDialogTitle

So in this case I suppose they should be something like OnStartupAddBrowse and OnStartupAddRecents, unless there is a possibility to use them elsewhere in the future.

@yaira2
Copy link
Member

yaira2 commented Feb 26, 2021

@nvi9 I think we can leave it how it is in this case as some settings get moved between the different pages, so it doesn't need to be as specific.

@nvi9 nvi9 deleted the startup_pages_from_sidebar branch February 26, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select current open pages as launch pages on startup.
2 participants