Feat/drives refactoring

[FelixZacher]

So i think i'm ready.

[lukeblevins]

Looks great, but I noticed we encounter a crash on app startup when running in a debugger which only occurs if File System access is denied. I would like to see this fixed before we merge the changes into settings-vm just to keep track of everything. Regardless, the newly modified branch will spend more time in testing before I incorporate the changes in v0.7.1 . Thanks!

[lukeblevins]

@lampenlampen Startup Crash info:
Windows.Graphics.Display: GetForCurrentView must be called on a thread that is associated with a CoreWindow.

[lukeblevins]

I'm guessing it has to do with the consent dialog which displays on startup because this exception only occurs when running in a debugger and file system access is disabled.

[FelixZacher]

So i can reproduce the crash, if the debugging option "Only my code" is enabled. If disabled, the crash does not occur.

[FelixZacher]

A guess:
consentDialog.ShowAsync() is somewhere called, before the Application CoreWindow is created, thus it fails to display the dialog ui.
And somehow the debugger delays the creation of the CoreWindow.

[FelixZacher]

I could fix it, by delaying the creation of the SettingsViewModel, until the constructor of App is called.

[lukeblevins]

@lampenlampen I'm still encountering a crash for some reason on the latest changes

[FelixZacher]

Yes there is a NullReferenceException at https://github.com/duke7553/files-uwp/blob/69902d4bb3e3f2d46b33c842057d2a982d66aaa5/Files/Filesystem/ListedItem.cs#L45
because datetimeformat is null at a fresh install.

We need to set a default value at startup, if it is null.
At https://github.com/duke7553/files-uwp/blob/69902d4bb3e3f2d46b33c842057d2a982d66aaa5/Files/View%20Models/SettingsViewModel.cs#L45
we should set a default value, if datetimeformat is null.

What should the default value be?

[yaira2]

The setting view model should have a default for every setting, the default for date and time format should be friendly date and times. For example "2 days ago".

[FelixZacher]

So we can choose between Application and System. I set it now to System.

[yaira2]

I think Application is the one with friendly dates...

[FelixZacher]

They are both with friendly dates.

Application	`4 days ago`, `15 hours ago`, `Saturady, October 12, 2019`
System	`4 days ago`, `15 hours ago`, `10/12/2019 5:14 PM`

[yaira2]

Ok, so lets set the default to application. That is how it was in previous versions of Files as well.

[yaira2]

Great, is this pull request ready for review now?

[FelixZacher]

Yes fixed a last bug and should be ready now 👍.