Skip to content

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented Feb 28, 2021

image

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 2, 2021

@winston-de
#3639 (comment)

+ Could you also add an option in settings to disable folder previews :)

@winston-de
Copy link
Contributor Author

@d2dyno1 Yeah, I could add an option to disable them.

Item tiles with names for folder preview would be perfect!

I'm not sure about item names, as my end goal is to achieve something like this:
image
The current GridView display is more of a rough prototype/proof of concept.

However, this is by no means set in stone, please let me know if you have any feedback and/or suggestions :)

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 2, 2021

I kinda want filenames to be displayed, but what if they were to be put in tooltips? @winston-de

@yaira2
Copy link
Member

yaira2 commented Mar 2, 2021

Could you also add an option in settings to disable folder previews :)

At the end of the day, I don't an option is necessary here. As long as the preview pane is open, it doesn't hurt to put information there. If the user doesn't want to see a preview, they can already hide the preview pane.

@winston-de
Copy link
Contributor Author

winston-de commented Mar 2, 2021

@d2dyno1
Personally, I would rather have it show just thumbnails, because I generally find thumbnails to be a better representation of what's in the file than it's name.
However, I could easily do both.
Perhaps instead of simply a toggle setting for folder previews, there was a drop-down with:

  • Tiles view
  • thumbnail view
  • none

Would that be a good solution?

Also, did you want to be able to disable folder details, too, or just the preview?

---edit---
@yaichenbaum I just saw your comment now.
What are your thoughts on having an option to change the style of folder previews?

@winston-de
Copy link
Contributor Author

winston-de commented Mar 9, 2021

I don't think having a tile view will work well, as it's slow to load.
As it turns out, StorageFolder has built in thumbnails, so I will just use those for the preview for the time being.

@winston-de winston-de marked this pull request as ready for review March 9, 2021 22:20
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 10, 2021
@yaira2 yaira2 changed the title Folder previews Added folder previews to the preview pane Mar 10, 2021
@yaira2 yaira2 merged commit 585c545 into files-community:main Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants