Skip to content

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented Mar 8, 2021

Closes #3809
This PR adds base support for theming, and selecting themes.
Not to be confused with light/dark themes, as these themes can utilize both.

You can test this by adding themes to the themes folder that should be created when you run the branch.

Themes are in the form of xaml files with resource dictionaries.

Basic example of theming:
image

image

winston-de and others added 4 commits March 8, 2021 12:38
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
Co-authored-by: Yair Aichenbaum <39923744+yaichenbaum@users.noreply.github.com>
@winston-de
Copy link
Contributor Author

@yaichenbaum x:load doesn't seem to support Binding, and x:Bind doesn't seem to work with the datacontext. To get around this, I moved ShowColorSchemeSelector to code-behind. Is this ok?

@yaira2
Copy link
Member

yaira2 commented Mar 8, 2021

@yaichenbaum x:load doesn't seem to support Binding, and x:Bind doesn't seem to work with the datacontext. To get around this, I moved ShowColorSchemeSelector to code-behind. Is this ok?

@winston-de That should be fine in this case.

@winston-de winston-de marked this pull request as ready for review March 8, 2021 21:13
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Mar 8, 2021
@winston-de winston-de requested a review from yaira2 March 8, 2021 22:11
@winston-de winston-de requested a review from yaira2 March 8, 2021 22:30
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winston-de Nice work! LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Mar 8, 2021
@yaira2 yaira2 changed the title Theming / Color schemes Added support for custom themes Mar 8, 2021
@yaira2 yaira2 merged commit 6c96e41 into files-community:main Mar 8, 2021
@winston-de winston-de deleted the Theming branch March 8, 2021 23:51
@d2dyno1
Copy link
Member

d2dyno1 commented Mar 15, 2021

@winston-de How does a theme file look like? How do I create one myself?

@yaira2
Copy link
Member

yaira2 commented Mar 15, 2021

@winston-de How does a theme file look like? How do I create one myself?

You can find instructions here https://files-community.github.io/docs/#/articles/custom-themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Custom Themes
3 participants