Skip to content

Conversation

nvi9
Copy link
Contributor

@nvi9 nvi9 commented Mar 8, 2021

Resolves #3498/1

@nvi9
Copy link
Contributor Author

nvi9 commented Mar 8, 2021

@yaichenbaum should I add app name or icon to the sidebar title?

image image

@yaira2
Copy link
Member

yaira2 commented Mar 8, 2021

@nvi9 Is it possible to only show the expand button when the sidebar is collapsed?

@nvi9
Copy link
Contributor Author

nvi9 commented Mar 8, 2021

@yaichenbaum that way one could only expand the sidebar, there would be no control for collapsing it just with resizing the window

Files-sidebarcollapse.mp4

@yaira2
Copy link
Member

yaira2 commented Mar 8, 2021

@nvi9 That shouldn't be an issue if you use LeftCompactMode when the window is sized small.

@nvi9 nvi9 marked this pull request as ready for review March 15, 2021 01:23
@nvi9 nvi9 requested a review from yaira2 March 15, 2021 01:23
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Mar 15, 2021
@nvi9 nvi9 requested a review from yaira2 March 15, 2021 23:47
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@yaira2 yaira2 changed the title Collapsible sidebar Added support for collapsing the sidebar Mar 15, 2021
@yaira2 yaira2 removed the changes requested Changes are needed for this pull request label Mar 15, 2021
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 15, 2021
@yaira2 yaira2 merged commit c21459f into files-community:main Mar 15, 2021
@nvi9 nvi9 deleted the 3498_collapse_sidebar branch March 16, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small window issues
3 participants