Skip to content

Fixes an issue for which drives are not removed from sidebar when disconnected #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Mar 21, 2021

Resolved / Related Issues

Fixes #4152
Fixes #4088

Details of Changes

Fixes an issue for which drives are not removed from sidebar / homepage when disconnected.
Adds a check in SyncSideBarItemsUI to remove drives when syncing MainPage.SideBarItems to the Drives list.

Validation

How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 21, 2021
@yaira2 yaira2 merged commit b866e7f into files-community:main Mar 21, 2021
@gave92 gave92 deleted the issue_4112 branch March 21, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side bar doesn't update when devices are unplugged Ejecting a USB should stop detecting it
2 participants