Skip to content

Fixed an issue where menu items were sometimes hidden #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fixed an issue where menu items were sometimes hidden #4277

merged 1 commit into from
Mar 24, 2021

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 24, 2021 •
edited
Loading

Fixes #4230

@yaira2 yaira2 requested a review from gave92 March 24, 2021 15:25
@gave92
Copy link
Member

gave92 commented Mar 24, 2021

Looks good but how is this for #4245?

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 24, 2021

@yaichenbaum So the Visibility works? Interesting why x:Load didn't 🤔

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 24, 2021
@yaira2
Copy link
Member Author

yaira2 commented Mar 24, 2021

@gave92 I typed the wrong issue number.

@yaira2 yaira2 merged commit f7b642b into main Mar 24, 2021
@yaira2 yaira2 deleted the NavItems branch March 24, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaira2 @gave92 @d2dyno1