Improve theme folder loading code and fix crash #4322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-de
changed the title
lukeblevins
approved these changes
Mar 27, 2021
gave92
approved these changes
Mar 27, 2021
gave92
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Itemize resolved / related issues by this PR.
Fixes
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/3820898840u/overview
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/3038526161u/overview
Details of Changes
Use the
CreationCollisionOption.OpenIfExistsoption instead of usingTryGetItemto check if it already exists.Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.