Fixed the problem of Settings page when in non-English environment. #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
approved these changes
Mar 15, 2020
|
Thank you! |
lukeblevins
added a commit
that referenced
this pull request
Mar 20, 2020
* Implement Win32 FileTimeToSystemTime * Handle/log exception during device StorageFolder initialization step * Prevent Pinning OneDrive Multiple Times * Add files via upload * Update Files.Package.wapproj * Copy assets * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Cleaned up assets Fixed null crash in SettingsViewModel * Revert * Add Property for Hiding File Extensions * Fixed crash on first launch * Added confirm delete ui * Added InteractionViewModel * Refactored PermanentlyDelete shortcut * Hooked up confirm to delete dialog * Fixed focus state on confirm to delete dialog * Added strings * Fixed focus issue for confirm delete dialog * Added a setting to turn off the delete confirmation dialog * Fixed delete item shortcut * Removed blank line * Refactored Sidebar.xaml.cs * Implement Hidden File Extensions Setting * Update Files.de-DE.xlf (#457) - Updated the translation - Fixed some typos in old strings * Fixed the problem of Settings page when in non-English environment. (#460) * Added buttons to the set custom location text boxes * Added the option to browse for setting custom folder loacations * Fixed bug with nav menu * Toned down reveal affect for the navigation menu * Correct an issue with getting file path for setting the desktop wallpaper * Setting the wallpaper photo now works * Refactored variable name * Updated nuget packages * Only show SetDesktopBackground on image files * Finished basic work on setting the desktop background * Fixed typo * Fixed bug with setting desktop wallpaper * Added a comment * Delete temp file when finished working with it * Revert last commit * Update Files.pl-PL.xlf (#463) Updated translation (#37) * Improve General Behavior of Sidebar * Add WinUI ItemsRepeater Workaround for Sidebar * Temporary fix for settings * Remove friendly names for locations * Simplify Pathbar Logic * Prevent crash on home navigation * Replace Start with New tab * Added strings for items in the sidebar * Update Files.de-DE.xlf (#469) Updated translation * Update azure-pipelines.yml for Azure Pipelines * Only update drives collection from UI Thread * Exclude extended item properties if generic Exception is caught * Fix crash on right click of pinned sidebar item * Increased version number * Fix bug with crash on copy path * Fix Photo Layout display Co-authored-by: Luke Blevins <lukeblevins15@gmail.com> Co-authored-by: R3voA3 <robertseibel@outlook.de> Co-authored-by: Creeper Lv <creeperlv@users.noreply.github.com> Co-authored-by: piotrulos <piotr.wwww@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the conflicts before, this time should work now. 🙇