Skip to content

Allow dragging items without selecting them first #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2021
Merged

Allow dragging items without selecting them first #4626

merged 2 commits into from
Apr 16, 2021

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented Apr 16, 2021 •
edited
Loading

Resolved / Related Issues
Itemize resolved / related issues by this PR.

Details of Changes

  • For all list view based layout modes (aka all but DataGrid), use built in drag and drop instead of the custom one currently used

This does not work with the DataGrid, but if we plan to switch to the ListView one anyway I don't think it's an issue.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Note
Most of the column view file changes are the xaml auto formatter (that's also why this PR is so large xD).

yaira2
yaira2 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Since we are switching to the ListView control, I think it's fine that it doesn't work in the DataGrid control.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 16, 2021
@yaira2 yaira2 merged commit 667cc1a into files-community:main Apr 16, 2021
@yaira2 yaira2 mentioned this pull request Apr 16, 2021
Closed
@winston-de winston-de deleted the 673 branch April 16, 2021 03:56
@tellmewhy12 tellmewhy12 mentioned this pull request May 25, 2021
Closed
@winston-de winston-de mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow dragging files and folders without selecting them first
2 participants
@winston-de @yaira2