Skip to content

Add shortcut keys for layouts #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2021
Merged

Conversation

cinqmilleans
Copy link
Contributor

@cinqmilleans cinqmilleans commented May 1, 2021

Add keyboard shortcuts for layouts: ctrl+shift+1/6.
Reorder layouts in menu, from the smallest to the biggest.
#4682

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels May 12, 2021
@cinqmilleans
Copy link
Contributor Author

@yaichenbaum This PR has become too complicated because it covers portions of code that have changed a lot. I propose to reapply the changes from the current state. I need to know what to do with the tooltips (see my post above).

yaira2
yaira2 previously approved these changes May 19, 2021
@yaira2 yaira2 requested review from winston-de and removed request for tsvietOK May 19, 2021 03:34
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels May 19, 2021
@yaira2
Copy link
Member

yaira2 commented May 19, 2021

@cinqmilleans Can you resolve the merge conflicts?

winston-de
winston-de previously approved these changes May 19, 2021
@winston-de winston-de dismissed stale reviews from yaira2 and themself via c5d6ce3 May 19, 2021 05:49
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels May 19, 2021
@cinqmilleans
Copy link
Contributor Author

@yaichenbaum This pr changes the order of the layouts from smallest to largest (column / detail / tile / grid small-> medium-> large), in the context menu and in the navigationtoolbar (which does not currently display the same order) . This is the order that is used for the shortcuts. So I did not apply your changes.

@yaira2
Copy link
Member

yaira2 commented May 19, 2021

@yaichenbaum This pr changes the order of the layouts from smallest to largest (column / detail / tile / grid small-> medium-> large), in the context menu and in the navigationtoolbar (which does not currently display the same order) . This is the order that is used for the shortcuts. So I did not apply your changes.

As discussed in the issue, we would prefer to keep the current order since it's arranged by what's used more often.

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum Ok for me. The changes you proposed only modify the tooltips. I'll edit to keep the current order.

@yaira2
Copy link
Member

yaira2 commented May 19, 2021

@yaichenbaum Ok for me. The changes you proposed only modify the tooltips. I'll edit to keep the current order.

Correct, that was just the general idea 🙂

@cinqmilleans
Copy link
Contributor Author

@yaichenbaum It is done.

yaira2
yaira2 previously approved these changes May 20, 2021
@yaira2 yaira2 requested a review from winston-de May 20, 2021 14:56
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels May 20, 2021
@winston-de
Copy link
Contributor

Looks good, but can you please resolve the merge conflicts?

@cinqmilleans
Copy link
Contributor Author

@winston-de You are right. The merge is resolved.

Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 21, 2021
@yaira2 yaira2 merged commit a52f54e into files-community:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants