-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add shortcut keys for layouts #4809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yaichenbaum This PR has become too complicated because it covers portions of code that have changed a lot. I propose to reapply the changes from the current state. I need to know what to do with the tooltips (see my post above). |
@cinqmilleans Can you resolve the merge conflicts? |
@yaichenbaum This pr changes the order of the layouts from smallest to largest (column / detail / tile / grid small-> medium-> large), in the context menu and in the navigationtoolbar (which does not currently display the same order) . This is the order that is used for the shortcuts. So I did not apply your changes. |
As discussed in the issue, we would prefer to keep the current order since it's arranged by what's used more often. |
@yaichenbaum Ok for me. The changes you proposed only modify the tooltips. I'll edit to keep the current order. |
Correct, that was just the general idea 🙂 |
@yaichenbaum It is done. |
Looks good, but can you please resolve the merge conflicts? |
@winston-de You are right. The merge is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
Add keyboard shortcuts for layouts: ctrl+shift+1/6.
Reorder layouts in menu, from the smallest to the biggest.
#4682