Skip to content

Add Ctrl+F shortcut to open search box #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2021
Merged

Conversation

gave92
Copy link
Member

@gave92 gave92 commented May 17, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.
Code taken from #3558

  • Adds "Ctrl + F" keyboard shortcut to open the searchbox and "Esc" to close it

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Ctrlf Add Ctrl+F shortcut to open search box May 17, 2021
@JaiganeshKumaran
Copy link
Contributor

Does it focus on the last focused element after you press esc? There was this bug in the original PR which I couldn't fix.

@gave92
Copy link
Member Author

gave92 commented May 18, 2021

Does it focus on the last focused element after you press esc? There was this bug in the original PR which I couldn't fix.

Code is the taken straight from #3558 (only rebased), has the same issue ;)

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label May 19, 2021
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels May 19, 2021
@yaira2 yaira2 merged commit 1a9277b into files-community:main May 19, 2021
@gave92 gave92 deleted the ctrlf branch May 19, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants