Skip to content

Fixed an issue where Files would crash when using high contrast themes #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2021
Merged

Fixed an issue where Files would crash when using high contrast themes #4969

merged 2 commits into from
May 21, 2021

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 21, 2021

  • Added missing brush to high contrast resources
  • Removed extra resources from app.xaml

Fixes #4319

@yaira2 yaira2 requested a review from winston-de May 21, 2021 00:01
@winston-de
Copy link
Contributor

winston-de commented May 21, 2021 •
edited
Loading

This may be unrelated, but it seems like there's no difference between the selected and unselected tabs in hc mode.
image
The tab on the right is the selected one.

@yaira2
Copy link
Member Author

yaira2 commented May 21, 2021

This may be unrelated, but it seems like there's no difference between the selected and unselected tabs in hc mode.
image
The tab on the right is the selected one.

@winston-de The brushes need to be updated but that's unrelated.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 21, 2021
@yaira2 yaira2 merged commit 017ac7c into main May 21, 2021
@yaira2 yaira2 deleted the Resources branch May 21, 2021 04:36
@yaira2 yaira2 mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@winston-de winston-de winston-de approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files Crashes when Use High Contrast [System] is enabled
2 participants
@yaira2 @winston-de