Skip to content

Added the option to use middle click to scroll #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 1, 2021
Merged

Added the option to use middle click to scroll #5065

merged 7 commits into from
Jun 1, 2021

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented May 30, 2021

Resolved / Related Issues

Details of Changes

  • Added middle mouse click to scroll.

Validation

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented May 30, 2021

@d2dyno1 Can this be added to the other layout modes?

@d2dyno1
Copy link
Member Author

d2dyno1 commented May 30, 2021

Can you try using the extension from the WCT (https://docs.microsoft.com/en-us/windows/communitytoolkit/extensions/FrameworkElementExtensions#cursor) instead?

I don't know if that's possible (Link for reference)

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels May 30, 2021
@yaira2
Copy link
Member

yaira2 commented May 30, 2021

@d2dyno1 is there a way to only toggle this when clicking in a blank area?

yaira2
yaira2 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jun 1, 2021
@yaira2 yaira2 changed the title Added middle click to scroll Added the option to use middle click to scroll Jun 1, 2021
@yaira2 yaira2 merged commit f719b05 into files-community:main Jun 1, 2021
@d2dyno1 d2dyno1 deleted the mid_scrl branch June 1, 2021 17:55
@yaira2 yaira2 mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll with middle mouse click
2 participants
@d2dyno1 @yaira2