Skip to content

Add security page to properties #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jun 6, 2021
Merged

Add security page to properties #5114

merged 31 commits into from
Jun 6, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jun 3, 2021 •
edited by yaira2
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Adds security tab to properties window

TODO

  • Persist changed permissions to filesystem
  • Implement "advanced permission options" -> next PR
  • UI polish

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Security props Add security page to properties Jun 3, 2021
@gave92 gave92 marked this pull request as draft June 3, 2021 09:37
@yaira2 yaira2 self-requested a review June 3, 2021 13:22
@gave92
Copy link
Member Author

gave92 commented Jun 4, 2021

Basic page is working!

image

@yaira2
Copy link
Member

yaira2 commented Jun 6, 2021 •
edited
Loading

Basic page is working!

@gave92 That looks great!

@gave92 gave92 marked this pull request as ready for review June 6, 2021 16:05
gave92
gave92 commented Jun 6, 2021
View reviewed changes
yaira2
yaira2 approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 6, 2021
@yaira2 yaira2 merged commit d3b88d5 into main Jun 6, 2021
@yaira2 yaira2 deleted the security_props branch June 6, 2021 17:17
@yaira2 yaira2 mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gave92 @yaira2