Skip to content

Conversation

winston-de
Copy link
Contributor

Resolved / Related Issues
Closes #1691

Details of Changes
Add details of changes here.

  • Added options to enter and exit compact overlay in the nav toolbar

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@winston-de Perhaps we should hold off on this until some of the other work around the toolbar has been completed.

@winston-de
Copy link
Contributor Author

@winston-de Perhaps we should hold off on this until some of the other work around the toolbar has been completed.

My thinking was that we would have the work done by the time we release 2.0 anyway so it wouldn't be an issue.

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@winston-de What do you think about adding a shortcut for this (alt + up/down)?

@winston-de
Copy link
Contributor Author

@winston-de What do you think about adding a shortcut for this (alt + up/down)?

good idea

@winston-de
Copy link
Contributor Author

@yaichenbaum What do you think about this for collapsing the multitasking control below certain widths?

2021-06-20-134839.mp4

@yaira2
Copy link
Member

yaira2 commented Jun 20, 2021

@winston-de It looks good! Just make sure to hide the button to create a new tab since it looks a little off without the tab control.

@winston-de
Copy link
Contributor Author

winston-de commented Jun 21, 2021

@winston-de What do you think about adding a shortcut for this (alt + up/down)?

I just realized, Alt+Up is used for moving up a directory.
How about ctrl+alt+up/down or just F12?

@yaira2
Copy link
Member

yaira2 commented Jun 21, 2021

@winston-de What do you think about adding a shortcut for this (alt + up/down)?

I just realized, Alt+Up is used for moving up a directory.
How about ctrl+alt+up/down or just F12?

That should work.

@winston-de
Copy link
Contributor Author

I added the ctrl+alt+up/down shortcuts, but when invoked they instead focus the next item in a list view. It only works once the focus indicator reaches the top or bottom of the list. Does anyone know how to fix this?

yaira2
yaira2 previously approved these changes Jun 22, 2021
@yaira2
Copy link
Member

yaira2 commented Jun 22, 2021

I added the ctrl+alt+up/down shortcuts, but when invoked they instead focus the next item in a list view. It only works once the focus indicator reaches the top or bottom of the list. Does anyone know how to fix this?

Is this still an issue if you use a different shortcut?

@gave92
Copy link
Member

gave92 commented Jun 22, 2021

Or you can look at how Alt+Up is handled in FileList_PreviewKeyDown.

@winston-de
Copy link
Contributor Author

Or you can look at how Alt+Up is handled in FileList_PreviewKeyDown.

Thanks, that fixed it.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 27, 2021
@yaira2 yaira2 merged commit 4168ba5 into main Jun 27, 2021
@yaira2
Copy link
Member

yaira2 commented Jun 27, 2021

@winston-de Great work!

@yaira2 yaira2 deleted the #1691 branch June 27, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact overlay mode
3 participants