-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Added compact overlay mode #5266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@winston-de Perhaps we should hold off on this until some of the other work around the toolbar has been completed. |
My thinking was that we would have the work done by the time we release 2.0 anyway so it wouldn't be an issue. |
@winston-de What do you think about adding a shortcut for this ( |
good idea |
@yaichenbaum What do you think about this for collapsing the multitasking control below certain widths? 2021-06-20-134839.mp4 |
@winston-de It looks good! Just make sure to hide the button to create a new tab since it looks a little off without the tab control. |
I just realized, Alt+Up is used for moving up a directory. |
That should work. |
I added the ctrl+alt+up/down shortcuts, but when invoked they instead focus the next item in a list view. It only works once the focus indicator reaches the top or bottom of the list. Does anyone know how to fix this? |
Is this still an issue if you use a different shortcut? |
Or you can look at how Alt+Up is handled in FileList_PreviewKeyDown. |
Thanks, that fixed it. |
@winston-de Great work! |
Resolved / Related Issues
Closes #1691
Details of Changes
Add details of changes here.
Validation
How did you test these changes?
Screenshots (optional)
