Skip to content

Added open with flyout to the right click context menu #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2021
Merged

Added open with flyout to the right click context menu #5708

merged 1 commit into from
Aug 8, 2021

Conversation

winston-de
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes #issue...
  • Related #issue...

Details of Changes
Add details of changes here.

  • After shell items are loaded, the standard open with option is replaced by one with a list of apps that the file can be opened with

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

gave92
gave92 approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@gave92 gave92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty amazing.

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Aug 7, 2021
@yaira2 yaira2 merged commit 97cf5a4 into main Aug 8, 2021
@yaira2 yaira2 deleted the cmupdate branch August 8, 2021 02:01
@yaira2 yaira2 changed the title Add "open with" flyout with app list to context menu Added open with flyout to the right click context menu Aug 8, 2021
MelvinSnijders pushed a commit to MelvinSnijders/Files that referenced this pull request Aug 9, 2021
@winston-de
Added open with flyout to the right click context menu (files-communi…
f227b55 
…ty#5708)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gave92 gave92 gave92 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winston-de @gave92 @yaira2