-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Added drop to Pin folder/s to Favorites #6129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps with this we can consider removing the "Pin to favorites" context menu option, or move it to the More submenu like "Pin to start". |
I would opt for the second option for now since users already expect the option to be in the menu. |
@BanCrash should there be a tooltip that says "Pin to favorites"? |
Do you mean this? If so, it's already on this PR (Anclar a Favoritos = Pin to favorites). In the screenshots of the first post it doesn't show it because it's not allowed (only shows the forbidden icon, as on other sections on the same scenario), but when the operation is allowed it will be show as expected. In the gif is being showed though. I will add this screenshot to the first post too. Or do you mean somewhere else? |
@BanCrash yes, that's what I meant. Looks good! |
Btw, about your comments @gave92 and @yaichenbaum , I agree about moving to the more submenu, but there are folders that you can only pin when you are inside, so removing this would cause that they couldn't be pinned to favorites. When my VS works again, I will work on it. |
Resolved / Related Issues
Details of Changes
You can drop several folders to Favorites at the same time. You can include files on the selection, but they will be ignored. You can include on the selection folders that are already pinned, but they will be ignored too.
Validation
Screenshots (optional)

With two files and folders selected:
When the operation is allowed:

With a folder that is already pinned selected the operation is not allowed:

Just adding files will not work neither:
