Skip to content

Conversation

BanCrash
Copy link
Contributor

@BanCrash BanCrash commented Sep 15, 2021

Resolved / Related Issues

Details of Changes

  • Added the ability to drop folder/s to favorites.

You can drop several folders to Favorites at the same time. You can include files on the selection, but they will be ignored. You can include on the selection folders that are already pinned, but they will be ignored too.

Validation

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
With two files and folders selected:
GIF 15-09-2021 14-30-01

When the operation is allowed:
image

With a folder that is already pinned selected the operation is not allowed:
image

Just adding files will not work neither:
image

@BanCrash BanCrash marked this pull request as draft September 15, 2021 13:01
@BanCrash BanCrash marked this pull request as ready for review September 15, 2021 14:41
@BanCrash
Copy link
Contributor Author

BanCrash commented Sep 15, 2021

I added a variable to fix a bug that caused to pin to favorites the folders that you copied / movied to a favorite folder using the sidebar.

I mean, doing this:

image

Without the last commit, will copy the folder and also pin it to Favorites. With the last commit will only copy it as expected.

@yaira2 yaira2 requested a review from tsvietOK September 17, 2021 01:48
@yaira2 yaira2 requested review from winston-de and removed request for tsvietOK September 17, 2021 21:23
@gave92
Copy link
Member

gave92 commented Sep 19, 2021

Perhaps with this we can consider removing the "Pin to favorites" context menu option, or move it to the More submenu like "Pin to start".

@yaira2
Copy link
Member

yaira2 commented Sep 19, 2021

Perhaps with this we can consider removing the "Pin to favorites" context menu option, or move it to the More submenu like "Pin to start".

I would opt for the second option for now since users already expect the option to be in the menu.

@yaira2
Copy link
Member

yaira2 commented Sep 19, 2021

@BanCrash should there be a tooltip that says "Pin to favorites"?

@BanCrash
Copy link
Contributor Author

BanCrash commented Sep 19, 2021

@BanCrash should there be a tooltip that says "Pin to favorites"?

Do you mean this?

image

If so, it's already on this PR (Anclar a Favoritos = Pin to favorites).

In the screenshots of the first post it doesn't show it because it's not allowed (only shows the forbidden icon, as on other sections on the same scenario), but when the operation is allowed it will be show as expected. In the gif is being showed though. I will add this screenshot to the first post too.

Or do you mean somewhere else?

@yaira2
Copy link
Member

yaira2 commented Sep 19, 2021

Do you mean this?

@BanCrash yes, that's what I meant. Looks good!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 19, 2021
@yaira2 yaira2 merged commit 2034ee6 into files-community:main Sep 19, 2021
@BanCrash BanCrash deleted the DropToPinToFavorites branch September 19, 2021 20:14
@BanCrash
Copy link
Contributor Author

Btw, about your comments @gave92 and @yaichenbaum , I agree about moving to the more submenu, but there are folders that you can only pin when you are inside, so removing this would cause that they couldn't be pinned to favorites.

When my VS works again, I will work on it.

@BanCrash BanCrash mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin folders by dropping them on left pane
4 participants