Fixed crash when opening folders in GridView #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaichenbaum this PR not fixes first folder opening, it fixes crash on other folder opening(except first) |
yaira2
changed the title
yaira2
changed the title
ghost
added
the
|
By the way, dragndrop is not working(drop part). |
|
@yaichenbaum dragndrop fixes: this line replace "pastedItems" with "itemsToPaste". I think we can add this change to this PR. |
|
@tsvietOK Have you tested that change and confirmed that it works? |
|
@yaichenbaum Yes. Before this change if you try to move one folder onto another folder it copying it and after removing just copied folder. Now it works |
|
Logically, i don't think it is a good idea to delete just moved files:) |
lukeblevins
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where opening folder in the GridView layout would sometimes crash the app.