Skip to content

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Nov 3, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Provide dragged files as StorageFile when possible. Fixes dropping to some UWP apps, e.g Snip and Sketch.

Validation
How did you test these changes?

  • Built and ran the app

@BanCrash
Copy link
Contributor

BanCrash commented Nov 3, 2021

@gave92 Do you test it with any app that didn't work with last Files release? I've tested with Email app and it doesn't work with this commit nor the last release.

@gave92
Copy link
Member Author

gave92 commented Nov 3, 2021

I've tried with snip & sketch. Doesn't work on main but it's working with this PR, could you confirm? I'll take a look to the Email app.

@BanCrash
Copy link
Contributor

BanCrash commented Nov 3, 2021

I've tried with snip & sketch. Doesn't work on main but it's working with this PR, could you confirm? I'll take a look to the Email app.

@gave92 Yep, I have your same result (last release not working but your PR does).

Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this fixes the issue you said, I don't see any reason to not merge this. LGTM.

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Nov 3, 2021
@yaira2 yaira2 merged commit 1c53ea6 into files-community:main Nov 3, 2021
@gave92 gave92 deleted the issue_6697 branch November 4, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dragging and dropping to other apps
3 participants