-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Apply theme and acrylic changes without restart #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Little bit increased acrylic opacity Some code cleaning
Can you keep the acrylic opacity the same as it was before? |
@yaichenbaum Let's compare: |
@tsvietOK I tested it myself, the first one is cleaner. |
@yaichenbaum As you wish |
If people really want we can add in a way to adjust it but I think that is taking it too far. |
@yaichenbaum For some reason ModernNavigationToolbar exists at home page, do you have the same problem? |
@tsvietOK What is the issue you are seeing? |
@yaichenbaum As you can see an screenshots above, bottom tool bar present at home page |
@tsvietOK I do not see that, but I will test again. |
@tsvietOK I don't see that issue. |
@yaichenbaum I have found it. This caused by 8f3083d |
As i understand, home page detection based on "New tab" string |
@tsvietOK To fix that we just need to update the check when navigating to a page to use the resource string. |
@yaichenbaum Your changes fixes this bug. |
Little bit increased acrylic opacity
Some code cleaning
For idea thanks to Microsoft
Known bugs:
Sometimes the theme of datagrid is not updated
May be some freeze while changing theme