Skip to content

Apply theme and acrylic changes without restart #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Apply theme and acrylic changes without restart #677

merged 4 commits into from
Apr 24, 2020

Conversation

tsvietOK
Copy link
Contributor

Little bit increased acrylic opacity
Some code cleaning
For idea thanks to Microsoft
Known bugs:
Sometimes the theme of datagrid is not updated
May be some freeze while changing theme

Little bit increased acrylic opacity
Some code cleaning
@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

Can you keep the acrylic opacity the same as it was before?

@tsvietOK
Copy link
Contributor Author

@yaichenbaum Let's compare:
Before:
Dark_Preview
Light_Preview
After:
Dark_Dev
Light_Dev

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

@tsvietOK I tested it myself, the first one is cleaner.

@tsvietOK
Copy link
Contributor Author

@yaichenbaum As you wish

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

If people really want we can add in a way to adjust it but I think that is taking it too far.

@ghost ghost added the needs - code review label Apr 24, 2020
@yaira2 yaira2 self-requested a review April 24, 2020 17:31
@tsvietOK
Copy link
Contributor Author

tsvietOK commented Apr 24, 2020

@yaichenbaum For some reason ModernNavigationToolbar exists at home page, do you have the same problem?
Edit: It is not part of this PR

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

@tsvietOK What is the issue you are seeing?

@tsvietOK
Copy link
Contributor Author

@yaichenbaum As you can see an screenshots above, bottom tool bar present at home page

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

@tsvietOK I do not see that, but I will test again.

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

@tsvietOK I don't see that issue.

@tsvietOK
Copy link
Contributor Author

@yaichenbaum I have found it. This caused by 8f3083d
And this bug is language dependent. If i change var tabLocationHeader back to "New tab", toolbar invisible at home page.

@tsvietOK
Copy link
Contributor Author

As i understand, home page detection based on "New tab" string

@yaira2
Copy link
Member

yaira2 commented Apr 24, 2020

@tsvietOK To fix that we just need to update the check when navigating to a page to use the resource string.

@yaira2 yaira2 merged commit d74d961 into files-community:develop Apr 24, 2020
@tsvietOK
Copy link
Contributor Author

@yaichenbaum Your changes fixes this bug.

@tsvietOK tsvietOK deleted the smooth-theme-change branch April 24, 2020 18:50
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants