Use async/await to read from the named pipe #7110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the same be done on the other side of the pipe connection? |
Yes, I can do it. I prefer to keep MR small. So, I can do it in another MR as the two changes can be merged independently. |
yaira2
approved these changes
Nov 28, 2021
|
The follow-up PR: #7130 |
gave92
approved these changes
Dec 2, 2021
gave92
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of Changes
ReadAsyncUTF8.GetStringon an incomplete buffer may generate invalid strings (example). The new code is using aMemoryStreamto get the message content until the message is complete.