Skip to content

Fix issues with keyboard focus in Details view #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 4, 2022
Merged

Fix issues with keyboard focus in Details view #7390

merged 13 commits into from
Jan 4, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 30, 2021 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • For Improving the new details view #4643
    • Allow tab selecting columns
    • Invoke headers with keyboard alone
    • Fix issue where columns can't be resized with keyboard only
  • Switch back to (custom) StickyHeaderBehavior for Details view to fix Tab key behavior on header
  • Allow to invoke footer button by keyboard in ListView and GridView
  • Removed unused "ContextItemsChangedEventArgs.cs", "AcrylicTheme.cs"

Known issues

  • Using arrow keys to modify columns width only resizes the header
  • Upon navigation the header gets focus. This is not really an issue, pressing down arrow will select the listview first item and explorer behaves similarly.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 requested a review from winston-de December 30, 2021 12:30
@gave92
Copy link
Member Author

gave92 commented Dec 30, 2021 •
edited
Loading

@winston-de could you check if you can still reproduce the bug you mentioned about StickyHeaderBehavior in this PR?

@yaira2
Copy link
Member

yaira2 commented Dec 30, 2021

Upon navigation the header gets focus. This is not really an issue, pressing down arrow will select the listview first item and explorer behaves similarly.

@gave92 if an item was already selected, will it have to focus?

@gave92
Copy link
Member Author

gave92 commented Dec 30, 2021

  • If an item is selected, pressing arrow down will move focus to that item
  • When an item is selected "programmatically" (e.g when navigating to the parent folder) it will have focus too

@gave92 gave92 mentioned this pull request Jan 3, 2022
Merged
1 task
@yaira2
Copy link
Member

yaira2 commented Jan 4, 2022

@gave92 #5681 still seems to be an issue when opening a directory from the sidebar that only has one item in it.

yaira2
yaira2 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 4, 2022
This was referenced Jan 4, 2022
Closed
Closed
@yaira2 yaira2 merged commit 6ef2300 into files-community:main Jan 4, 2022
@gave92 gave92 deleted the focus2 branch January 4, 2022 16:17
@yaira2 yaira2 mentioned this pull request Feb 7, 2024
Merged
8 tasks
@files-community files-community deleted a comment from gave92 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@winston-de winston-de Awaiting requested review from winston-de

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Rename - Keyboard shortcut Ctrl-Shift moving focus out To be able to move with the arrows once i entered the folder
2 participants
@gave92 @yaira2